Guard against missing list values #7747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7747
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit e08e5c7 with merge base 07113ec ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68344960 |
swolchok
added
the
release notes: runtime
dbort
added
topic: not user facing
and removed
release notes: runtime
tarun292
approved these changes
Jan 21, 2025
dbort
force-pushed
the
export-D68344960
branch
from
a11e1d6 to
c3090be
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68344960 |
Summary: We checked for missing lists on some types, but not all. Add checks to everything in method.cpp that calls `->items()`. Reviewed By: tarun292 Differential Revision: D68344960
dbort
force-pushed
the
export-D68344960
branch
from
c3090be to
e08e5c7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68344960 |
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Differential Revision: D68344960 Pull Request resolved: #7747
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Differential Revision: D68344960 Pull Request resolved: pytorch#7747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We checked for missing lists on some types, but not all. Add checks to everything in method.cpp that calls
->items().Differential Revision: D68344960